Skip to content

fix: normalize vectorized histogram bin indices - #1210

Merged
henryiii merged 2 commits into
scikit-hep:developfrom
AryanRG:fix-vectorized-bin-indices
Nov 17, 2026
Merged

henryiii merged 2 commits into
scikit-hep:developfrom
AryanRG:fix-vectorized-bin-indices

Conversation

@AryanRG

@AryanRG AryanRG commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

NumPy array indices can select the wrong bins. For example, h[np.array([-1])] reads or overwrites the underflow bin while h[-1] selects the last regular bin. Out-of-range array indices can also silently select flow bins.

This checks bounds and normalizes negative indices before adding the flow offset. Converting to intp also prevents narrow integer arrays from wrapping during that offset. Boolean arrays now raise IndexError, consistent with this API's documented integer-array input.

Extended the existing flow-offset test. It fails on the original code and passes with the fix. The full suite passes with 1300 passed and 4 expected failures, and all applicable prek hooks pass on the changed files. Independent review checked get/set, category axes, storage types and mixed indexing.

Tested on macOS arm64, Python 3.12 and NumPy 2.5.5. The minimum NumPy version was not tested locally.

Prepared with AI assistance.

AryanRG and others added 2 commits November 16, 2026 18:57
Name the axis in the out-of-range error, wrap negatives in place on one
copy, and test non-integer arrays, setitem, and multi-axis cases.

Assisted-by: ClaudeCode:claude-opus-5-5
@henryiii

Copy link
Copy Markdown
Member

Pushed a fix.

@henryiii
henryiii merged commit 82a63a7 into scikit-hep:develop Nov 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants